Graph icon indicating copy to clipboard operation
Graph copied to clipboard

GetDotByDotOrId will not check the validity of the id

Open sinabakh opened this issue 8 years ago • 2 comments

Abstraction Layer's GetDotByDotOrId will not check if the given id number exist on graph or no.

sinabakh avatar Jul 13 '16 19:07 sinabakh

@pmkary It seems to be a bigger problem than it appears. Cause we can't simply return False since it breaks the design pattern.

In other hands it seems GetDotByNumberId will return an empty Dot if no dot is found. What really happens when it return the empty Dot ? and is there an easy way to check if it returned an empty Dot ?

sinabakh avatar Jul 13 '16 19:07 sinabakh

@sinabakh that's interesting...

pouyakary avatar Jul 13 '16 19:07 pouyakary