sssh

sssh copied to clipboard

Can we remove `Box::leak`s?

5

I don't know the use case of the `Box::leak`s we have in the source code. Maybe always convert to `String`. Maybe you can use [Cow](https://doc.rust-lang.org/std/borrow/enum.Cow.html) instead.

omid

save password

4

Thanks for your fantastic project. As a useful improvement, It seems good to add "save password" feature for each username. I mean something like [this](https://github.com/mrunderline/ssh-manager).

mrunderline

Remove `let _`

4

There are many `let _`s, most of them (or maybe all of them) are useless in your code.

omid

There are many clones

3

The code is full of `clone`s, `cloned`, `copied` and so on. :) Now it's like PHP :P

omid

Use Traits for subcommands

2

If it's possible, I think it's a better practice to use trait to define [subcommands](https://github.com/pouriya/sssh/tree/23.03.05/src/subcommands).

omid

Isn't Enum better for WorkingKeys?

2

It looks like WorkingKeys can be an Enum. And so [`state.working_keys`](https://github.com/pouriya/sssh/blob/23.03.05/src/subcommands/select.rs#L176) can be a simple array, or if you insist for the uniqueness, it can be a BTreeSet.

omid

Clippy is your mate

2

Clippy is your mate, even if you sleep with it `nightly`!

omid