ClassicUPS icon indicating copy to clipboard operation
ClassicUPS copied to clipboard

ClassicUPS ain't a pep8 name

Open mw44118 opened this issue 10 years ago • 3 comments

I hate to be that guy, but pep 8 wants packages to be all lower case

Modules should have short, all-lowercase names. Underscores can be used in the module 
name if it improves readability. Python packages should also have short, all-lowercase
names,although the use of underscores is discouraged.

http://legacy.python.org/dev/peps/pep-0008/#package-and-module-names

But more important than that, thanks so much for writing and pushing up this code! I needed it and you really helped me out.

Matt

mw44118 avatar Sep 08 '14 16:09 mw44118

What do you think would be a good interface for importing/instantiating/working with this package?

poundifdef avatar Sep 14 '14 02:09 poundifdef

I would call it something that emphasizes it is a client for the UPS API. Like maybe upsclient.

What's the story behind "classic"?

mw44118 avatar Oct 22 '14 18:10 mw44118

Good question. This organization, Eponym, Inc., makes eyewear for many fashion brands.

Before that, the company only made one line of eyewear, "Classic Specs," giving rise to this eponymous UPS library.

poundifdef avatar Oct 23 '14 21:10 poundifdef