Pierre

Results 161 comments of Pierre

@stof I don't want to be rude, but it's been many times that realpath() over-use in both Twig and Symfony caused us such trouble. Problem is that you force symbolic...

@fabpot I'd be glad to help, since it's recurrent problem for us, I can easily test patches in affected projects, but I can also help patching, since I start to...

I created a PR #2709 that illustrate a way to solve this, by avoiding all calls to realpath() replacing it by a normalizePath() method that does not check for file...

Please PR #2709 is ready for review. My ``\Twig_Loader_Filesystem::normalizePath()`` may seem a bit complex, but it's actually working well. I did attempt a few other alternative implementations see https://gist.github.com/pounard/4c242bf94e36d4e8f8f1ae68021ec45c in...

Still no reviews or discussion about this ?

> We cannot take a decision by saying "this does not happen when using Twig with Symfony" as Twig is used by way more people than just the Symfony community...

> Reading the code, I'm wondering if we cannot "just" remove the realpath call in the constructor. As we are calling realpath on the full template filename later on, it...

> And there is only thing we say to PR ! Not today. I always love to place a good quote. Joke aside, I'll try to manage some spare time...

Another option for passing new parameters would be to pre-populate options with a set of "global" options directly when the registry creates the anonymizers.

~~Please do not review yet, this will be rebased on top of #225.~~ EDIT: OK it's ready.