laravel-localization-helpers icon indicating copy to clipboard operation
laravel-localization-helpers copied to clipboard

Published 20 hours ago • verified publisher icon potsky

Laravel 5.6 compatibility

Open limenet opened this issue 7 years ago • 5 comments

Laravel 5.6 is out and it doesn't seem like much has changed: https://laravel.com/docs/5.6/upgrade except PHP >= 7.1.3 being required which results in the build on PHP 7.0 to fail.

It'd be great if this package supported Laravel 5.6!

I'm not sure against which branch I should send the PR to adhere to your versioning scheme: https://github.com/potsky/laravel-localization-helpers#1-installation

Let me know if you'd like me to make any changes!

Also, please see https://github.com/potsky/laravel-localization-helpers/pull/69#issuecomment-366932548 for why I upgraded satooshi/php-coveralls.

limenet avatar Feb 20 '18 10:02 limenet

Now all tests are passing except the ones using Microsoft's Translator Service: Please provide a client_key for Microsoft Translator service.

limenet avatar Feb 20 '18 10:02 limenet

Any plans on merging this?

imbrish avatar Mar 17 '18 09:03 imbrish

Hello, @limenet any news on this? @potsky can you help solving the tests? Thank you!

ldanielduarte avatar Apr 09 '18 14:04 ldanielduarte

Hi ! creating a new company, hiring, fund raising... no more time to check the PR, create new branches for new laravel versions, etc...

Does anyone want to be a collaborator on the repository to manage it

potsky avatar Apr 09 '18 15:04 potsky

@limenet you are already involved. Go for it! :muscle:

ldanielduarte avatar Apr 09 '18 15:04 ldanielduarte