laravel-localization-helpers icon indicating copy to clipboard operation
laravel-localization-helpers copied to clipboard

Obsolete strings never go back into main array

Open gwenth opened this issue 9 years ago • 2 comments

Hi !

I don't know if this is voluntary or not but if you decide to use obsolete strings that have already been translated and call a localization:missing, the command will end up with Drink a Piña colada and/or smoke Super Skunk, you have nothing to do!

IMHO, the problem is the strings still remain in obsolete array and are not moved back into the main array.

That's more a thought than an issue but I think it could be useful if you were able to do it in both ways.

Have a nice day :)

gwenth avatar Jun 15 '16 13:06 gwenth

Hi @gwenth,

in fact if an obsolete string is used again, it should go the main block and not stay in the obsolete one. I need to check this behaviour.

potsky avatar Sep 29 '16 09:09 potsky

I just have pushed a commit with a test for this behaviour and it is ok, I cannot reproduce your problem.

The test scan file1 with only Lemma1. Then it scans file2 with only Lemma2. And finally it scans file1 again.

  • Lemma1 is generated in lang file
  • Then Lemma1 is obsolete and Lemma2 is generated
  • Finally Lemma1 is moved from obsolete array to the main array and Lemma2 is pushed to the obsolete array

potsky avatar Sep 29 '16 10:09 potsky