potpie icon indicating copy to clipboard operation
potpie copied to clipboard

Restrict Further Sharing of Shared Chats in Chat API

Open vineetshar opened this issue 1 year ago • 7 comments

Description: Currently, the chat-sharing feature permits secondary sharing, where users with whom a chat is shared (e.g., User B) can share it further with others (e.g., User C). This creates potential privacy and control concerns, as the original chat creator may not intend for additional sharing.

Proposed Solution:

  • Implement restrictions within the Chat API that prevent secondary users from sharing the chat further.
  • Only the original creator (User A) should retain the permission to share access.

Tasks:

  • [ ] Update the chat-sharing logic to restrict further sharing permissions to only the chat creator.
  • [ ] Add checks within the API to verify user permissions before allowing share actions.
  • [ ] Test the sharing restrictions to confirm expected behaviour.

Acceptance Criteria:

  • Only the original creator can share a chat.
  • Secondary users (those with whom a chat is shared) are restricted from sharing the chat further.

vineetshar avatar Oct 30 '24 13:10 vineetshar

could you assign this to me?

malikrohail avatar Nov 03 '24 19:11 malikrohail

Hey sure @malikrohail feel free to pick this up.

vineetshar avatar Nov 08 '24 16:11 vineetshar

on it, could you pls share repo guidelines for the pull request?

malikrohail avatar Nov 08 '24 16:11 malikrohail

@malikrohail I dont think we are enforcing a lot yet. Just ensure you follow semantic titles and add comments in code & description in pull request with curl screenshots / api call screenshots as proof of functionality.

vineetshar avatar Nov 11 '24 18:11 vineetshar

Hi @malikrohail let us know if you need any help

dhirenmathur avatar Nov 15 '24 10:11 dhirenmathur

@dhirenmathur should this not be closed too?

vineetshar avatar Dec 05 '24 20:12 vineetshar

Is this issue still open

SuvasisOqlous avatar Mar 28 '25 15:03 SuvasisOqlous