homm3tools icon indicating copy to clipboard operation
homm3tools copied to clipboard

Fix seer huts

Open Dergash opened this issue 8 years ago • 1 comments

  • Fix for #4 issue - now seer huts with 'return artifact' quest type should converts correctly. If seer hut gives a quest which not supported by RoE/HD, or desired artifact is from AB/SoD, then hut stays empty, with no quest (will it be under #16 customization?).
  • Moved constants for quests and rewards to separate .h files, so a couple of lines to h3lib project file.
  • h3m_common provides a handful of useful types so I based fix on types from this file, but I also had to add types for: single resource slot, single primary skill slot, spell points, morale and luck.

Dergash avatar Feb 29 '16 01:02 Dergash

@Dergash, thanks a lot for this PR, it has some good additions and it would be cool to get #4 fixed

If #16 is implemented it would indeed influence what to do if the quest/reward is non-RoE.

I added some comments for things I saw that would need to be changed, take a look if you have time.

Regarding indentation, I'm not religious in the tabs vs spaces debate, but I think it's good to be consistent and not have mixed indentation. For example the code currently shows with messy indentation at github because the added lines have tabs instead of spaces like the rest of the code.

potmdehex avatar Feb 29 '16 06:02 potmdehex