ember-crumbly
ember-crumbly copied to clipboard
Changes for a more flexible Component
In order to generalize this component to have it more flexible I made some changes.
I removed the filters (for index and loading) and the Breadcrumb Classes.
Other then that I changed the breadcrumb behavior a bit so you need to define a
breadCrumb
object in order to have a breadcrumb at this route. (if nothing is defined it will not show anything)
I also added the routeHierarchy to the block of the bread-crumbs
component, so you can check inside the block whether its the last/first routeObject.
I hope that's in your favor.
:umbrella: The latest upstream changes (presumably #91) made this pull request unmergeable. Please resolve the merge conflicts.
I merged every thing and also, the test should also pass now also with the new code styling validations
@jakubikan I'll review your changes as soon as possible
:umbrella: The latest upstream changes (presumably #111) made this pull request unmergeable. Please resolve the merge conflicts.
This breaks backwards compatibility in multiple places. Interesting idea around index segments. I'll keep this open for now...