ember-crumbly icon indicating copy to clipboard operation
ember-crumbly copied to clipboard

Changes for a more flexible Component

Open jakubikan opened this issue 8 years ago • 5 comments

In order to generalize this component to have it more flexible I made some changes.

I removed the filters (for index and loading) and the Breadcrumb Classes.

Other then that I changed the breadcrumb behavior a bit so you need to define a breadCrumb object in order to have a breadcrumb at this route. (if nothing is defined it will not show anything)

I also added the routeHierarchy to the block of the bread-crumbs component, so you can check inside the block whether its the last/first routeObject.

I hope that's in your favor.

jakubikan avatar Aug 01 '16 06:08 jakubikan

:umbrella: The latest upstream changes (presumably #91) made this pull request unmergeable. Please resolve the merge conflicts.

homu avatar Sep 15 '16 19:09 homu

I merged every thing and also, the test should also pass now also with the new code styling validations

jakubikan avatar Sep 15 '16 20:09 jakubikan

@jakubikan I'll review your changes as soon as possible

fsmanuel avatar Oct 17 '16 19:10 fsmanuel

:umbrella: The latest upstream changes (presumably #111) made this pull request unmergeable. Please resolve the merge conflicts.

homu avatar Mar 19 '17 04:03 homu

This breaks backwards compatibility in multiple places. Interesting idea around index segments. I'll keep this open for now...

dguettler avatar Mar 19 '17 04:03 dguettler