ember-changeset
ember-changeset copied to clipboard
add #removeError and #removeErrors to Changeset interface
This is dependent on this PR being merged first, and then the validated-changeset
version being bumped: https://github.com/validated-changeset/validated-changeset/pull/189
The same description applies here:
I'm using ember-changeset with ember-changeset-validations with some validations where the presence requirement of one field is dependent on the value of another. If the dependent field ends up with an error and then the field it depends on changes, the error should really be cleared. But it didn't seem like there was a clean way to do that without actually rolling back the property. This seems to have come up a number of times in issues and PRs.
This seems to be something that works in the newer
validated-changeset
4.x-5.x experiment, but is not something available in the classic BufferedChangeset.
https://github.com/poteto/ember-changeset/issues/361 https://github.com/poteto/ember-changeset/issues/282
There were some workarounds in the above threads, like effectively "clearing" an error by changeset.addError('email', null), but in my testing it still left the changeset with an isValid = false state.
This PR adds removeError and removeErrors to the Changeset interface