ember-changeset-validations icon indicating copy to clipboard operation
ember-changeset-validations copied to clipboard

`buildMessage` function is backwards incompatible

Open brandynbennett opened this issue 7 years ago • 2 comments

Version

Latest Master starting at #126

Test Case

Steps to reproduce

Expected Behavior

From the Docs and existing behavior the buildMessage function should have a signature like this: buildMessage(key, type, value, context = {}).

Actual Behavior

On this line the signature made a backwards incompatible change and now looks like this: buildMessage(key, result).

Is the next release intended to bump the major version? If not, any apps relying on buildMessage will be broken.

brandynbennett avatar May 01 '17 22:05 brandynbennett

I've just updated to 1.2.7 and run into this incompatibility.

lozjackson avatar May 21 '17 11:05 lozjackson

Another breaking change is moving the context.message block after this logic which forces consumers to specify a type even when you plan on using context.message to get the validation message.

k-dauda avatar Feb 16 '22 23:02 k-dauda