djangae icon indicating copy to clipboard operation
djangae copied to clipboard

Published 20 hours ago • verified publisher icon potatolondon

Replace yaml.load with yaml.full_load

Open llarco opened this issue 5 years ago • 5 comments

Fixes #[include a number of issue this PR is fixing].

Summary of changes proposed in this Pull Request:

  • yaml.load is deprecated. This PR replaces it with yaml.full_load

PR checklist:

  • [N/A] Updated relevant documentation
  • [N/A] Updated CHANGELOG.md
  • [N/A] Added tests for my change

llarco avatar Mar 22 '19 15:03 llarco

Thanks for submitting this.

All the tests on this fail with AttributeError: 'module' object has no attribute 'full_load'. Or at least, they do on Travis. Do the tests pass for you locally?

If so then maybe the setup on Travis is using a different version of yaml to the one that gets used when running the tests locally.

adamalton avatar Apr 01 '19 10:04 adamalton

Fixes #1169.

adamalton avatar Apr 01 '19 10:04 adamalton

If there is no need to use the full set of YAML features, we should use yaml.safe_load() not yaml.full_load().

davidwtbuxton avatar Apr 01 '19 16:04 davidwtbuxton

Sorry for the delay! Switching it to safe_load worked and did not require a different version of pyyaml.

llarco avatar May 26 '19 08:05 llarco

Potentially related: https://github.com/potatolondon/djangae/pull/1163#discussion_r298198217

jacobg avatar Jun 27 '19 14:06 jacobg