Eduardo San Martin Morote comments

Results 866 comments of


                                            Eduardo San Martin Morote

chore(playground): upgrade to `script setup` syntax and TypeScript

Thanks for this, it's a long overdue! I have quite a few other things to cover before this so it will most definitely take me a few months before merging...

3.0.1,3.0.2,3.0.3 - devtoolsApi is not defined

The devtools API has indeed been removed from the iifee given the considerable size increase. It has to be included manually. This should be added to docs (migration guide) and...

3.0.1,3.0.2,3.0.3 - devtoolsApi is not defined

Yeah, ideally the devtools should expose an iife version for this to work

Using event handler with `RouterLink` combined with `vueCompilerOptions` `strictTemplates` gives TS error

I thought the RouterLink component was already accepting the allowed props but maybe not.

Using event handler with `RouterLink` combined with `vueCompilerOptions` `strictTemplates` gives TS error

It should be good although they are lost if the component is passed `custom` prop. It's worth making the RouterLink component generic for this. It might be more complicated than...

Component beforeRouteUpdate not triggered after hmr

It's indeed an HMR bug with the options API only (works with `onBeforeRouteUpdate()`). Contribution welcome!

feat(extendRoutes): allow relative paths in EditableTreeNode

Do you have a bug reproduction? This doesn't seem to be fixing something 😅 Changing paths with non absolute routes is not supported yet #341

feat(extendRoutes): allow relative paths in EditableTreeNode

The fullPath shouldn’t change its behavior, or at least it shouldn’t be needed

feat(extendRoutes): allow relative paths in EditableTreeNode

Looking good. I will probably give this a review and merge next Monday during the stream

fix: throw when a store is used outside of a Nuxt-aware context.

Thanks for the great description of the problem! I agree it's a nice addition