postman-docs icon indicating copy to clipboard operation
postman-docs copied to clipboard

Update SEO.jsx to serve dynamic values for 'content'

Open tristandenyer opened this issue 4 years ago β€’ 7 comments

The open graph and twitter cards are still serving static values for content.

We need to update these to use dynamic values pulled in from URL, like we do dynamically for og:title

Screen Shot 2020-04-20 at 10 55 49 PM

tristandenyer avatar Apr 21 '20 06:04 tristandenyer

@tristandenyer Should this go to someone else? (Just checked, and it looks like it's still there.)

jkonrath-postman avatar Jun 11 '21 16:06 jkonrath-postman

@jkonrath-postman Looks to still be an issue. Will reassign on my end. Also, this could be a good issue for the community to pick up. I believe there are enough patterns existing in that file to expand on for this.

tristandenyer avatar Jun 14 '21 05:06 tristandenyer

Hey can you assign me this issue?

tanay123456789 avatar Jan 25 '22 09:01 tanay123456789

Hi @tanay123456789, thanks for helping us out πŸš€ Let me know if you have any questions 🎸

ch264 avatar Jan 28 '22 18:01 ch264

Ok so right now I am working on this issue and during testing, I encountered an issue while running npm run test:urlπŸ‘‡πŸ‘‡πŸ‘‡

[email protected] test:url if grep -lri 's3.amazonaws.com/postman-static-getpostman-com' ./v6 ; then echo invalid s3 references found. Please use format; exit 1; else echo no s3 references found; fi

grep: ./v6: No such file or directory no s3 references found

Is this really the problem? If yes then please provide me with some inputs on resolving it.

tanay123456789 avatar Jan 29 '22 15:01 tanay123456789

Also, I ran another test, npm run dev which also failed so I am working to sort that issue also and so it's my humble requestπŸ™ to give me some time

tanay123456789 avatar Jan 29 '22 15:01 tanay123456789