openapi-to-postman icon indicating copy to clipboard operation
openapi-to-postman copied to clipboard

Add the alwaysInheritAuthentication option

Open AndrewGuenther opened this issue 3 years ago • 9 comments

This option forces all requests to inherit auth from the top of the collection. This is really useful when all requests should be using the same authentication. If authentication is called out on each request in the Postman app, they will not inherit the options set on the collection, like the token, and must all be set manually. By allowing all requests to simply inherit from the collection, the token can be set once at the top of the collection and all requests will use it automatically.

Fixes #271

AndrewGuenther avatar Jan 22 '22 08:01 AndrewGuenther

@VShingala would appreciate some eyes on this

AndrewGuenther avatar Feb 04 '22 01:02 AndrewGuenther

@SahilChoudhary22 can I get a review on this?

AndrewGuenther avatar Aug 09 '22 05:08 AndrewGuenther

@SahilChoudhary22 can I get a review on this? I would very much appreciate this feature. Hopefully it can be reviewed/approved soon!

PhMatt avatar Aug 09 '22 12:08 PhMatt

@AndrewGuenther Sure, planning to review this before releasing the next version 👍

SahilChoudhary22 avatar Aug 10 '22 13:08 SahilChoudhary22

Hey @SahilChoudhary22 , any update on this?

LevinFaber avatar Mar 17 '23 15:03 LevinFaber

Would be really great to have this!

jsbrain avatar Mar 18 '23 06:03 jsbrain

@AndrewGuenther Thanks for your contributions to the module. After reviewing the pull request, I noticed an area where I could use some additional clarity. I've left a comment on that line.

That being said, since the PR is now outdated and now the openapi-to-postman has 2 versions of converter within it, we will need to make some additional changes to add the support for alwaysInheritAuthentication to convertV2, along with the respective test cases. I will be raising another pull request shortly, where I'll be cherry-picking the changes from this PR and the added support for v2. 🙇 Stay tuned!

SahilChoudhary22 avatar Mar 21 '23 11:03 SahilChoudhary22

Hey @SahilChoudhary22, thanks for reviewing this PR. You mentioned that you would be raising another pull request that would supersede this one. Has there been any progress on that front?

tmccnnll avatar May 23 '23 14:05 tmccnnll

Hi @tmccnnll , I've raised the PR here - https://github.com/postmanlabs/openapi-to-postman/pull/728 The new option should be available with the next release of the module ie. 4.14.x

SahilChoudhary22 avatar May 29 '23 09:05 SahilChoudhary22