npm-cli-login icon indicating copy to clipboard operation
npm-cli-login copied to clipboard

Move snyk to devDependencies

Open madbence opened this issue 5 years ago • 2 comments

I don't think that snyk is a real dependency, so i moved it to devDependencies

madbence avatar May 16 '19 09:05 madbence

@czardoz could you merge this, please? :smile_cat:

madbence avatar May 21 '19 19:05 madbence

Yes please – having it as a dependency, in addition to installing a lot of unneeded stuff, now causes warnings like this when installing on node 8, even though npm-cli-login itself still works fine on node 8:

npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.14.7"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]

due to

+-- [email protected]
...
| `-- [email protected]
|   +-- @snyk/[email protected]
|   | +-- @snyk/[email protected] extraneous
|   | +-- @snyk/[email protected] deduped
|   | `-- [email protected]
|   +-- @snyk/[email protected]
|   | +-- @snyk/[email protected] deduped
|   | +-- @snyk/[email protected] deduped
|   | +-- [email protected]
|   | +-- [email protected] extraneous
...

cwalther avatar Aug 12 '20 09:08 cwalther