Update to Warn User for invalid Folder #2791

[pulkit-30]

Fixes #2791 Issue ' Warning or Error if --folder specified is invalid.'

What changes have been made? When the user provides the wrong folder, it will warn the user, Folder (--folder name) not found, in the console.

Why is this change necessary? When a user accidentally provides the wrong folder Name, then Newman doesn't show any error or warning in the console. To provide a better user experience this feature must be included. I work on that issue and solved that issue. Now, if the user passes a wrong folder, then it shows a warning, ' Folder (--folder name) not found ' in the console.

when the user provides two or more the wrong folder

when user provide one valid and one invalid folder

when the user provides an invalid folder only

What side effects does this change have? This issue doesn't have any side effects. It passes all the test cases.

[pulkit-30]

Please provide me appropriate feedback/review so that I can continue working on this.

[pulkit-30]

hey @shamasis , Can you provide me appropriate feedback/review so that I can continue working on this.

[pulkit-30]

@coditva Thanks for your review. I will commit the changes as soon as possible.

[codecov[bot]]

Codecov Report

Merging #2843 (f02fe02) into develop (18e0b53) will decrease coverage by 0.06%. The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop    #2843      +/-   ##
===========================================
- Coverage    90.96%   90.90%   -0.07%     
===========================================
  Files           21       21              
  Lines         1151     1165      +14     
  Branches       349      353       +4     
===========================================
+ Hits          1047     1059      +12     
- Misses         104      106       +2     

Flag	Coverage Δ
cli	81.20% <7.14%> (-0.91%)	:arrow_down:
integration	40.60% <7.14%> (-0.41%)	:arrow_down:
library	58.88% <85.71%> (+0.32%)	:arrow_up:
unit	75.02% <71.42%> (-0.05%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/run/index.js	92.95% <85.71%> (-0.80%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18e0b53...f02fe02. Read the comment docs.

[pulkit-30]

Hey @coditva, I have fixed the problem with the folder nested inside another folder. kindly review the changes and provide me appropriate feedback so that I can continue working on this.

Your idea to stop the run with an error message cannot be implemented, it doesn't pass the test cases.

[pulkit-30]

Please provide me with feedback on this PR.

[pulkit-30]

Hey @coditva , I tried to figure out the reason for the failure of these tests but couldn't find anything. May you please help me out with How can I solve these Errors.

[pulkit-30]

Hey @coditva @shamasis , Please review this PR and provide me with appropriate feedback so that I can continue working on this.

[pulkit-30]

Thanks, @shamasis for your reviews, I will address review comments in a couple of days, I'm extremely sorry for my late response 😞

[dvanderent]

Great if you could finish this; I found out, only after a couple of months, my pipeline test was false-positive...