pgcat icon indicating copy to clipboard operation
pgcat copied to clipboard

tag container with release tags

Open DeoLeung opened this issue 2 years ago • 6 comments

Hi,

It will be better if the container could be tagged using the release tags, it will be much more easy to find target versions.

DeoLeung avatar Jun 20 '23 08:06 DeoLeung

@levkk what do you think about pushing the builds only in the main tag and all tags?

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags

the config in build-and-push.yaml will be something like this:

# ...
on:
  push:
    branches:    
      - main
    tags:
      - v*

Let me know if you agree so I can send another PR.

sebastianwebber avatar Jul 14 '23 15:07 sebastianwebber

That works I think.

levkk avatar Jul 14 '23 15:07 levkk

there we go: https://github.com/postgresml/pgcat/pull/508

sebastianwebber avatar Jul 14 '23 15:07 sebastianwebber

Before closing this issue, do you think that it will be nice to add a goreleaser config file to automatically generate a release when a new tag is created?

sebastianwebber avatar Jul 14 '23 15:07 sebastianwebber

@levkk I noticed that you merged my PR. It worked for the main branch, is the case to create a new tag to validate it? Something like v1.0.1 should work.

sebastianwebber avatar Jul 14 '23 21:07 sebastianwebber

Will test it out as soon as I can release the next version. Probably early next week, we're overdue for a release!

levkk avatar Jul 15 '23 02:07 levkk