pgcat icon indicating copy to clipboard operation
pgcat copied to clipboard

A lot of metics not implemented warn logs.

Open Cluas opened this issue 2 years ago • 3 comments

Describe the bug A lot of metics not implemented warn logs.

Screenshots image

Cluas avatar Apr 24 '23 08:04 Cluas

Looking at the prometheus metrics it seems also these are not updated/not filled:

pgcat_stats_total_xact_time
pgcat_stats_avg_errors
pgcat_stats_avg_xact_time
pgcat_servers_query_count
pgcat_servers_error_count

jbub avatar Apr 27 '23 08:04 jbub

@levkk By reading the code, it seems this is generated by a debug! macro. I understand that implementing all of those metrics might be a big deal. But can it use at least the correct logging severity (IMO DEBUG severity) so that they can be ignored in the logger level?

tmizohata-alist avatar Jun 26 '23 21:06 tmizohata-alist

Sure. Implementing those metrics shouldn't be too difficult either, you can refer to the admin database for implementation. PRs for either paths are welcome.

levkk avatar Jun 26 '23 21:06 levkk