simperby

simperby copied to clipboard

DMS is only for a single height. There must be a mechanism that follows up to the latest finalized block which does not rely on DMS. One most natural solution...

junha1

As we decided to directly present the repository to the user (instead having a local git server), we must assume that the user will work on the repository, leaving many...

junha1

If two different data have the same binary representation, it will be a disastrous vulnerability. One easy solution is always attaching an unique Hash for different place where `TypedSignature` take...

junha1

For example, - Remove `Clone` - Prevent direct display through `Debug`

junha1

junha1

- [ ] Rename `simperby-common` to `simperby-core` - [ ] Rename `simperby-node` to `simperby`

junha1

Add WASM compile CI for `simperby-common`

1

Those two crates will be imported by the contract side, so there must be no dependencies that breaks WASM compatibility. Having a CI pipeline that checks such integrity would help.

junha1

You will need conditional compile using cargo `feature`

junha1

single_server_propose_1 keeps failing in CI with the following logs. ``` failures: ---- single_server_propose_1 stdout ---- Checking node #0 The application panicked (crashed). Message: assertion failed: `(left == right)` left: `[]`,...

fakedev9999

Remove trait `RawRepository` and directly present `RawRepositoryImpl`

1

`RawRepositoryImpl` should be renamed to `RawRepository` and implement the method directly (not as a trait) I think we don't have another implementation of it.

junha1