simperby icon indicating copy to clipboard operation
simperby copied to clipboard

Implement tests for `CommitSequenceVerifier`

Open fakedev9999 opened this issue 2 years ago • 1 comments

There are several tests prepared but yet not implemented since extra-agenda transaction related features are under development.

After all features need for these tests are implemented, the tests should be implemented. (Related PRs: #178, #303)

Tests are in common > src > verify.rs and the list of 12 tests is as below:

  • [x] #467
  • [x] phase_mismatch_for_agenda_commit3
  • [x] phase_mismatch_for_agenda_proof_commit3
  • [x] invalid_delegate_transaction_with_invalid_delegator1
  • [x] invalid_delegate_transaction_with_invalid_delegator2
  • [x] invalid_delegate_transaction_with_invalid_delegatee
  • [x] invalid_delegate_transaction_with_invalid_signature
  • [ ] invalid_delegate_transaction_with_invalid_timestamp
  • [x] invalid_undelegate_transaction_with_invalid_delegator1
  • [ ] invalid_undelegate_transaction_with_invalid_delegator2
  • [x] invalid_undelegate_transaction_with_invalid_signature
  • [ ] invalid_undelegate_transaction_with_invalid_timestamp

Please refer to other tests in the same file and implement tests in the same manner.

fakedev9999 avatar Feb 23 '23 05:02 fakedev9999

Since not all tests are covered, I'll reopen the issue.

fakedev9999 avatar Jul 29 '23 15:07 fakedev9999