postcss-color-function icon indicating copy to clipboard operation
postcss-color-function copied to clipboard

Deprecate or replace with postcss-color-mod-function

Open jonathantneal opened this issue 5 years ago • 15 comments

Are there any developers interested in continuing this project, or should we deprecate it in favor of https://www.npmjs.com/package/postcss-color-mod-function ?

Note that, regardless of the name, the entire color-mod() function concept is deprecated.

jonathantneal avatar Aug 13 '18 13:08 jonathantneal

Any update on this?

standy avatar Oct 12 '18 13:10 standy

I never know if the lack of response means a lack of interest, or that any other interested parties are just busy, or if I just did a bad job explaining the issue.

jonathantneal avatar Oct 12 '18 14:10 jonathantneal

@jonathantneal I can understand your issue, and share the interest in the response.

am avatar Nov 04 '18 18:11 am

I'm a confused, why would this plugin be deprecated in favor of a deprecated concept? In any case, I like this plugin and would like to help maintain it, especially to solve #49.

silvenon avatar Nov 11 '18 22:11 silvenon

I do not want the color-mod to disappear color-mod is really useful!

jeonghoheo avatar Mar 03 '19 04:03 jeonghoheo

@jonathantneal Are you still looking for somebody to take over supporting this project? If so, I'd be happy to dig in. I'm about to fork it to see if I can either figure out why an issue is happening or fix it if I have found a bug.

trezy avatar Mar 12 '19 16:03 trezy

This is great news. If we can get some smaller PRs, I will review and hand out maintainer status that way. Then after I can review a few npm publishes, I can hand over access there, too. I hope you don’t mind the gated philosophy; we’ve seen what happens we hand out access too easily and all the sudden bitcoin miners are distributed across npm.

jonathantneal avatar Mar 22 '19 16:03 jonathantneal

A smaller PR was brought in and released as 4.1.0.

jonathantneal avatar Apr 01 '19 23:04 jonathantneal

@jonathantneal I don't really understand the readme. Are both color() and color-mod() deprecated?

EasterPeanut avatar Apr 15 '19 10:04 EasterPeanut

I'm also curious about this. Is the CSS Color Module Level 4 spec introducing a different syntax or tool to solve the same problem? Or has the concept of color manipulation in CSS been removed from the spec completely?

Paul-Hebert avatar Apr 18 '19 17:04 Paul-Hebert

Appearently it has been removed here: https://github.com/w3c/csswg-drafts/commit/034b063697c3dadf144504f52e0858a79cd84414

The commit message states:

when we add it back it will have different syntax.

So, it's going to be added again, but most likely in a way that will cause a breaking change in the postcss-color-mod-function plugin in order to stay compatible.

grebaldi avatar Jun 05 '19 15:06 grebaldi

It will have a different syntax, yes (coincidentally we are discussing that syntax at today's CSS Working Group meeting)

svgeesus avatar Jun 05 '19 18:06 svgeesus

@EasterPeanut, it’s complicated, but yes, both the color() or color-mod() spec are deprecated.

First, the CSS function named color() was renamed to color-mod(), while another completely different function named color() was implemented in a web browser. When I heard about this change, I brought it to the attention of the folks who managed this project. Nothing happened, I made the color-mod() plugin, put it into PostCSS Preset Env, and then fast forward a few years and now I manage this project.

This is why the README says “color() was changed to color-mod().

Second, the function named color-mod() was deprecated and removed because it had a “bad” syntax and no one had time to properly work on it. When I said “the entire color-mod() function concept” I could have been more precise and said “the entire color-mod() function syntax”. I was excited to learn the idea was being revisited.

But this is why the README says “color-mod() has been removed from Color Module Level 4 specification.


@Paul-Hebert, by removing the color-mod() spec then yes, technically “the concept of color manipulation in CSS” was “removed from the spec completely”, but that’s not the same as saying the concept is a bad idea. The spec being removed meant the syntax was bad, and there was no longer a spec to address that concept.


Now, since my original request, I have received 2 maintenance PRs and neither contributor stuck around. I’ll talk with other PostCSS team members to see what we should do with this repo.

jonathantneal avatar Jun 05 '19 18:06 jonathantneal

Cool, thanks for the additional info, @grebaldi , @svgeesus , @jonathantneal !

Paul-Hebert avatar Jun 05 '19 20:06 Paul-Hebert