positron icon indicating copy to clipboard operation
positron copied to clipboard

Assistant's 'Add Language Model' button is hidden behind an ellipsis menu

Open rodrigosf672 opened this issue 8 months ago • 2 comments

System details:

Positron and OS details:

Positron Version: 2025.06.0 (Universal) build 39 Code - OSS Version: 1.99.0 Commit: 55dad0b8cac13849ee986eb3f46c75cfcaa599e0 Date: 2025-05-08T03:32:55.440Z Electron: 34.3.2 Chromium: 132.0.6834.210 Node.js: 20.18.3 V8: 13.2.152.41-electron.0 OS: Darwin arm64 24.4.0

Interpreter details:

Python 3.13.0

Describe the issue:

Assistant's 'Add Language Model' button is hidden behind an ellipsis menu.

Steps to reproduce the issue:

  1. Add a language model. Then, after having interacted with it, attempt to add a second language model.
  2. Notice that the button to add another model will be hidden behind an ellipsis menu, which is not ideal when only one item is present, making it difficult for user to find it.

Expected or desired behavior:

'Add Language Model' location is easily accessible and visible to the user. See potential location in screenshot below.

Image

rodrigosf672 avatar May 08 '25 18:05 rodrigosf672

We should add an "Add Provider" option to the provider dropdown and remove the "Add Language Model" from the ellipsis menu. We are adding Providers and not actually adding individual models but a list of models from a Provider.

Image

jthomasmock avatar May 12 '25 18:05 jthomasmock

@jthomasmock Yes, that would work. One note though: when user clicks on the dropdown, currently selected provider should not appear in the dropdown list. So in your dropdown, for example, I'd expect that Anthropic should not be present. What do you think?

rodrigosf672 avatar May 12 '25 18:05 rodrigosf672

Verified Fixed

Positron Version(s) : 2025.07.0-49 OS Version(s) : Windows 11

Test scenario(s)

Add model provider selection no longer under the ellipses, but on top bar. And a button on welcome page when none are registered

Image

e2e tests were updated with the new buttons & locators

jonvanausdeln avatar Jun 05 '25 21:06 jonvanausdeln