positron icon indicating copy to clipboard operation
positron copied to clipboard

Generated Ark comm plot_comm.rs has manual edits

Open wesm opened this issue 1 year ago • 0 comments

Running the comm generator modifies plot_comm.rs (and removing the manual edit results in compilation failure):

diff --git a/crates/amalthea/src/comm/plot_comm.rs b/crates/amalthea/src/comm/plot_comm.rs
index dd5cb542..89f6a320 100644
--- a/crates/amalthea/src/comm/plot_comm.rs
+++ b/crates/amalthea/src/comm/plot_comm.rs
@@ -22,7 +22,7 @@ pub struct PlotResult {
 }
 
 /// Possible values for Format in Render
-#[derive(Clone, Debug, Serialize, Deserialize, PartialEq, strum_macros::Display)]
+#[derive(Clone, Debug, Serialize, Deserialize, PartialEq)]
 pub enum RenderFormat {
   #[serde(rename = "png")]
   Png,
@@ -108,3 +108,4 @@ pub enum PlotFrontendEvent {
   Show,
 
 }
+

This is a small annoyance when updating the comms from the OpenRPC definitions, but it would be good to fix.

wesm avatar Jul 03 '24 20:07 wesm