posit-dev
Runtime/notebook integration may be causing stability problems in Jupyter notebooks
Positron Version:
Positron Version: 2024.06.1 (system setup) build 2024.06.1-27 Code - OSS Version: 1.90.0 Commit: a893e5b282612ccb2200102957ac38d3c14e5196 Date: 2024-06-26T01:33:58.809Z Electron: 29.4.0 Chromium: 122.0.6261.156 Node.js: 20.9.0 V8: 12.2.281.27-electron.0 OS: Windows_NT x64 10.0.22621
Steps to reproduce the issue:
- Open a Jupyter Notebook
- Run a random cell
To be honest, I don't know how to reproduce the problem. It works fine for me before but not now
What did you expect to happen?
The cell run
Were there any error messages in the output or Developer Tools console?
The cell didn't run. As can be seen from the screenshot, it took 11 minutes and not yet finished package loading
If this happens in a reproducible way for you (or even if something seems to make it happen more often), please do share that with us!
One possible issue I can see from the code is that we aren't listening to and handling session.onDidEndSession in the NotebookSessionService for potential errors after startup.
Something like this may also be behind https://github.com/posit-dev/ark/issues/707?
Verified Fixed
Positron Version(s) : 2025.01.0-32 OS Version(s) : MacOS
Test scenario(s)
Confirmed that basic running and interrupting cells in the notebook works as expected. The real test of this fix will be whether it reduces the flakiness of our automated notebook-create tests. We’ve occasionally encountered issues where a simple cell execution hangs in CI, and hopefully this change fixes that.
Link(s) to TestRail test cases run or created:
n/a
