positron icon indicating copy to clipboard operation
positron copied to clipboard

Save buttons on menu bar don't work

Open jonvanausdeln opened this issue 1 year ago • 2 comments

Positron Version:

Positron Version: 2024.02.0 (system setup) build 2024.02.0-1535 Code - OSS Version: 1.86.0 Commit: 1478e597a716c434509a1ff8f7e0e43dbf420cb2 Date: 2024-02-15T02:51:08.089Z Electron: 27.2.3 ElectronBuildId: undefined Chromium: 118.0.5993.159 Node.js: 18.17.1 V8: 11.8.172.18-electron.0 OS: Windows_NT x64 10.0.22631 Also on MacOS

Steps to reproduce the issue:

  1. Start Positron and create a new file (any type)
  2. Click the Save button image

Observe that nothing happens, as if the buttons were inactive

What did you expect to happen?

The OS save file dialog to save the file

Notes

The command palette, Ctrl + s and File -> Save all work as expected. The buttons also don't work if you modify an existing file and attempt to save with the buttons.

jonvanausdeln avatar Feb 16 '24 17:02 jonvanausdeln

@sharon-wang would you be able to take a look at this?

petetronic avatar Jul 04 '24 14:07 petetronic

Not sure if it's because the icons are deactivated, but it would be nice to have a tooltip show up when hovering the mouse over each icon.

ryjohnson09 avatar Jul 04 '24 14:07 ryjohnson09

Verified Fixed

Positron Version(s) : 2024.07.0-21 OS Version(s) : Windows 11, Ubuntu 22 (From CI), MacOS 14

Test scenario(s)

Buttons now work as expected.

Link(s) to TestRail test cases run or created:

Smoke test created and TestRail test added: C633087 C656252 C656251

jonvanausdeln avatar Jul 09 '24 19:07 jonvanausdeln