positron icon indicating copy to clipboard operation
positron copied to clipboard

View plot in editor space

Open timtmok opened this issue 1 year ago • 6 comments

Add a way to allow a user to view a plot as an editor. This allows a larger view without altering the size of the plots pane and leverages the editor's ability to float as its own window or tile along other editors/plots.

timtmok avatar Feb 15 '24 18:02 timtmok

Requested (more or less) by beta user: https://github.com/posit-dev/positron-beta/discussions/122

jmcphers avatar Apr 18 '24 00:04 jmcphers

I have been doing some prep for teaching a workshop, and I really want this feature.

juliasilge avatar Jun 06 '24 13:06 juliasilge

Relevant Mastodon thread:

The only weird thing is no zoom option for plotting.

https://mastodon.online/@[email protected]/112695382560885990

jmcphers avatar Jun 28 '24 17:06 jmcphers

Sort of requested in https://github.com/posit-dev/positron/issues/3884.

seeM avatar Jul 05 '24 07:07 seeM

I think as long as we have a really good encapsulation of the IPositronPlotClient class it should be relatively straightforward to write an EditorPane/EditorInput class that can act as the front-end.

Work done for #1713 will probably make this easier as it will involve making the front-end as stateless as possible.

nstrayer avatar Jul 23 '24 16:07 nstrayer

In RStudio there is a very useful option to show data/plots/viewer/console without having to split panels, it just expands the panels using shortcut keys.

Tools>Modify Keyboard Shortcuts>Zoom. It's really fast.

I think it might be really cool if we had that on the Positron.

https://github.com/user-attachments/assets/5051bd09-7b7c-4bb9-9bb1-47e711d00640

factorialmap avatar Jul 23 '24 19:07 factorialmap

I'll start some QA notes for the initial version of this! 🎉

QA Notes

  • The new ability to open a plot in editor space should be behind a feature flag where the default is off.

juliasilge avatar Sep 05 '24 21:09 juliasilge

Verified Fixed

Positron Version(s) : 2024.09.0-27
OS Version          : OSX

Test scenario(s)

Open in editor works well. No controls yet in editor I assume is expected.

Link(s) to TestRail test cases run or created: N/A

testlabauto avatar Sep 11 '24 16:09 testlabauto