positron icon indicating copy to clipboard operation
positron copied to clipboard

positron CLI returns VS Code version

Open jthomasmock opened this issue 2 years ago • 4 comments

Positron Version: Positron Version: 2023.09.0 (Universal) build 203 Code - OSS Version: 1.79.0 Commit: 519fbc791a60d21275cb20c3b8214202b99605a2 Date: 2023-09-22T02:37:21.484Z Electron: 22.3.10 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin arm64 22.6.0

Steps to reproduce the issue:

  1. call positron --version
  2. get back 1.79.0

What did you expect to happen?

Get the Positron version rather than VS Code version: IE: 2023.09.0 (Universal) build 203

I'd also prefer this over having to go to About and copying the Positron version manually

Were there any error messages in the output or Developer Tools console?

jthomasmock avatar Sep 22 '23 17:09 jthomasmock

Workbench will need to be able to call this so that we can support changes to positron over time.

MariaSemple avatar Sep 26 '23 00:09 MariaSemple

Another place we check the version, but without invoking the CLI: https://github.com/rstudio/rstudio-pro/blob/main/src/cpp/server/extras/scripts/install-vs-code-ext.sh.in#L66-L70

MariaSemple avatar Sep 26 '23 22:09 MariaSemple

Also reported by @blairj09: https://positpbc.slack.com/archives/C05M2EZCPGR/p1708372707054269.

Added to the Posit Workbench epic: #1617

jmcphers avatar Feb 20 '24 16:02 jmcphers

QA Notes

  • PR with fix for positron --version: #5072
  • DEB/RPM Version info is in a separate issue: https://github.com/posit-dev/positron/issues/5159
  • Other known areas in Positron where Positron version info is missing: https://github.com/posit-dev/positron/issues/5101

sharon-wang avatar Oct 24 '24 16:10 sharon-wang

Verified Fixed

Positron Version(s) : 2024.11.0-103
OS Version          : ubuntu

Test scenario(s)

positron --version works now on ubuntu

Link(s) to TestRail test cases run or created:

testlabauto avatar Oct 25 '24 14:10 testlabauto