Handle tilde
This PR adds support for auto-completion of file paths starting ~ which
translate to user home dir
Signed-off-by: anmolbabu [email protected]
Codecov Report
Merging #79 into master will decrease coverage by
3.97%. The diff coverage is54.28%.
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 89.93% 85.95% -3.98%
==========================================
Files 14 15 +1
Lines 864 961 +97
==========================================
+ Hits 777 826 +49
- Misses 77 117 +40
- Partials 10 18 +8
| Impacted Files | Coverage Δ | |
|---|---|---|
| args.go | 100% <100%> (ø) |
:arrow_up: |
| predict_files.go | 95.12% <100%> (ø) |
:arrow_up: |
| test_utils.go | 39.47% <39.47%> (ø) |
|
| utils.go | 80% <90.9%> (+10%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 43c37e8...689e335. Read the comment docs.
@posener Please review
@posener: Yo, could we get this and #80 reviewed + merged? :)
Hi Codey,
Thanks for contributing! I'm sorry, but I see some issues with this PR, and therefore I can't merge it.
- It is currently too complicated to be added to the code base. I would have want this implementation to be much simpler.
- I think it contains irrelevant changes?
- It conflicts with changes that already merged into the master branch?
If you want we can work on this PR together in order to make it possible to merge it.
@posener Whoops! I should check GH more often. If I get some free cycles before anyone else does, I'd be happy to. :)