portfolio
portfolio copied to clipboard
New pdf importer for Sunrise
New pdf importer for https://www.meetsunrise.com/
Hello @auchri Thanks for this pull request. I would redesign the whole thing as a section and change the transaction type based on the character (plus or minus). As an example --> here <--
You can also take a look at the new variant of the test cases... --> here <-- These are more simply structured....
Regards Alex
I have no time to adjust the whole importer and the tests to the new structure. Feel free to change it 😊
I have no time to adjust the whole importer and the tests to the new structure. Feel free to change it 😊
That's not a problem... 😇
Just set the pull request to "draft", then we'll wait until you've found the time. 👍
@buchen @Nirus2000 I've created a new importer for the "new" bank. Please have a look now.
Hello,
I have a quick question about the structure of PDF importer, since I am currently also working on a new one.
Does the importer class (in that case SunrisePDFExtractor) need to be added to the PDFImportAssistent to be usable in PP? (name.abuchen.portfolio\src\name\abuchen\portfolio\datatransfer\pdf\PDFImportAssistant.java)
My assumption was, that if it is not added, test cases would pass but PP actually would not recognize the PDF.
Thanks!
Why is this importer not included in the new release? 😔 @buchen
Hello @auchri thats right... @MonkeySon
Add in PDFImportAssistant.java...
Hello @auchri Thx for the changes... 👍🏻 I add the importer in the import assistent.
Rebase and merge