portfolio icon indicating copy to clipboard operation
portfolio copied to clipboard

New pdf importer for Sunrise

Open auchri opened this issue 1 year ago • 5 comments

New pdf importer for https://www.meetsunrise.com/

auchri avatar Jan 13 '24 14:01 auchri

Hello @auchri Thanks for this pull request. I would redesign the whole thing as a section and change the transaction type based on the character (plus or minus). As an example --> here <--

You can also take a look at the new variant of the test cases... --> here <-- These are more simply structured....

Regards Alex

Nirus2000 avatar Jan 15 '24 09:01 Nirus2000

I have no time to adjust the whole importer and the tests to the new structure. Feel free to change it 😊

auchri avatar Jan 15 '24 18:01 auchri

I have no time to adjust the whole importer and the tests to the new structure. Feel free to change it 😊

That's not a problem... 😇

Just set the pull request to "draft", then we'll wait until you've found the time. 👍

Nirus2000 avatar Jan 15 '24 20:01 Nirus2000

@buchen @Nirus2000 I've created a new importer for the "new" bank. Please have a look now.

auchri avatar Feb 05 '24 17:02 auchri

Hello,

I have a quick question about the structure of PDF importer, since I am currently also working on a new one.

Does the importer class (in that case SunrisePDFExtractor) need to be added to the PDFImportAssistent to be usable in PP? (name.abuchen.portfolio\src\name\abuchen\portfolio\datatransfer\pdf\PDFImportAssistant.java)

My assumption was, that if it is not added, test cases would pass but PP actually would not recognize the PDF.

Thanks!

MonkeySon avatar Mar 08 '24 08:03 MonkeySon

Why is this importer not included in the new release? 😔 @buchen

auchri avatar Mar 08 '24 20:03 auchri

Hello @auchri thats right... @MonkeySon

Add in PDFImportAssistant.java...

Nirus2000 avatar Mar 13 '24 05:03 Nirus2000

Hello @auchri Thx for the changes... 👍🏻 I add the importer in the import assistent.

Rebase and merge

Nirus2000 avatar Mar 23 '24 03:03 Nirus2000