porter-archive icon indicating copy to clipboard operation
porter-archive copied to clipboard

capi preflight checks [do not merge]

Open jusrhee opened this issue 1 year ago • 1 comments

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [ ] If it's a backend change, tests for the changes have been added and go test ./... runs successfully from the root folder.
  • [ ] If it's a frontend change, Prettier has been run
  • [ ] Docs have been reviewed and added / updated if needed

What is the current behavior?

What is the new behavior?

Technical Spec/Implementation Notes

jusrhee avatar Apr 03 '23 22:04 jusrhee

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
1250243 Generic Private Key e02afb22042d4018509bedda8321c6578253de7f docker/localhost.key View secret
1250243 Generic Private Key 9a37496bf151321970a348903da1f0e9d0fc102e docker/localhost.key View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Apr 03 '23 22:04 gitguardian[bot]