porter-archive icon indicating copy to clipboard operation
porter-archive copied to clipboard

[POR-689] Add DNS 1123 validation to request body validator

Open mnafees opened this issue 3 years ago • 0 comments

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [x] Other (please describe): Improvement

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] If it's a backend change, tests for the changes have been added and go test ./... runs successfully from the root folder.
  • [ ] If it's a frontend change, Prettier has been run
  • [ ] Docs have been reviewed and added / updated if needed

What is the current behavior?

Kubernetes uses the DNS 1123 naming convention. We do not validate for this in our request handlers which might lead to lost compute cycles in the form of this error being caught only by Helm and/or Kubernetes in a later stage.

What is the new behavior?

Add DNS 1123 name validation to the request body validator.

Technical Spec/Implementation Notes

mnafees avatar Sep 20 '22 12:09 mnafees