porter-archive icon indicating copy to clipboard operation
porter-archive copied to clipboard

`porter update` throws error

Open anukul opened this issue 3 years ago • 1 comments

Description

porter update throws error

Error: repository name must be canonical

image

Can also be seen at https://github.com/anukul/gin-example/runs/3303306850?check_suite_focus=true

Location

  • [ ] Browser
  • [x] CLI
  • [ ] API

Steps to reproduce

  1. Connect a docker image repository from Docker Hub
  2. Deploy app from git repository

Additional Details

Image repository used: https://hub.docker.com/repository/docker/anukulsangwan/gin-example Git repository used: https://github.com/anukul/gin-example

anukul avatar Aug 11 '21 17:08 anukul

Tried running this locally in debug mode.

Error is thrown by docker's reference.ParseNamed which we're calling from GetServerURLFromTag:

image

No error if I add this line in GetServerURLFromTag before calling reference.ParseNamed:

image = strings.Replace(image, "index.docker.io", "docker.io", -1)

anukul avatar Aug 11 '21 17:08 anukul

Fixed with https://github.com/porter-dev/porter/pull/2359

mnafees avatar Oct 20 '22 20:10 mnafees