fix(stack): fix lifecycle hook from not getting called, issue #12452
closes #12452
Changes:
Added project to api.StartOptions for api.UpOptions in stack Deploy.
Any movement here. I'm having issues because of this.
@chris-gputrader you did the background research on this on the Docker repo issue. I would suggest cross posting it to help explain how this fix works and to validate the approach. It will help encourage the merge.
Sure, as I was digging into the issue I initially thought this had to do with the compose library and created an issue here: https://github.com/docker/compose/issues/12513
After debugging and getting help from the compose community I found out that we had to add Project to the Deploy and Remove functions in the portainer compose plugin.
There is an edge case that I haven't figured out though. This works fine when a stack gets Deployed, or Removed. If a container is restarted these don't trigger because container start/stop/restart don't use the compose plugin.
Any progress on this PR?