ocean icon indicating copy to clipboard operation
ocean copied to clipboard
Published 1 month ago • verified publisher icon port-labs

[Core] Implement a url string formatting for links

Open mk-armah opened this issue 7 months ago • 4 comments

Description

What -

Why -

How -

Type of change

Please leave one option from the following and delete the rest:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] New Integration (non-breaking change which adds a new integration)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Non-breaking change (fix of existing functionality that will not change current behavior)
  • [ ] Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • [ ] Integration able to create all default resources from scratch
  • [ ] Resync finishes successfully
  • [ ] Resync able to create entities
  • [ ] Resync able to update entities
  • [ ] Resync able to detect and delete entities
  • [ ] Scheduled resync able to abort existing resync and start a new one
  • [ ] Tested with at least 2 integrations from scratch
  • [ ] Tested with Kafka and Polling event listeners
  • [ ] Tested deletion of entities that don't pass the selector

Integration testing checklist

  • [ ] Integration able to create all default resources from scratch
  • [ ] Resync able to create entities
  • [ ] Resync able to update entities
  • [ ] Resync able to detect and delete entities
  • [ ] Resync finishes successfully
  • [ ] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
  • [ ] If resource kind is updated, run the integration with the example data and check if the expected result is achieved
  • [ ] If new resource kind is added or updated, validate that live-events for that resource are working as expected
  • [ ] Docs PR link here

Preflight checklist

  • [ ] Handled rate limiting
  • [ ] Handled pagination
  • [ ] Implemented the code in async
  • [ ] Support Multi account

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

mk-armah avatar May 15 '25 11:05 mk-armah

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1630.d1ftd8v2gowp8w.amplifyapp.com

aws-amplify-eu-west-1[bot] avatar May 15 '25 11:05 aws-amplify-eu-west-1[bot]

Code Coverage Artifact 📈: https://github.com/port-labs/ocean/actions/runs/15043702588/artifacts/3130546534

Code Coverage Total Percentage: 80.51%

github-actions[bot] avatar May 15 '25 11:05 github-actions[bot]

Code Coverage Artifact 📈: https://github.com/port-labs/ocean/actions/runs/15043829341/artifacts/3130595693

Code Coverage Total Percentage: 80.51%

github-actions[bot] avatar May 15 '25 11:05 github-actions[bot]

Code Coverage Artifact 📈: https://github.com/port-labs/ocean/actions/runs/15046221918/artifacts/3131444328

Code Coverage Total Percentage: 80.61%

github-actions[bot] avatar May 15 '25 13:05 github-actions[bot]