countryinfo icon indicating copy to clipboard operation
countryinfo copied to clipboard

Please add Myanmar and its info (currencies, etc)

Open tanagnostis opened this issue 3 years ago • 3 comments

Hi!

Is it possible to add Myanmar and its info?

Thanks

tanagnostis avatar Dec 08 '21 11:12 tanagnostis

There's already an entry about Burma. As far as I can see, the library doesn't yet have an approach to handle situations like that.

voidus avatar Feb 04 '22 20:02 voidus

There's already an entry about Burma. As far as I can see, the library doesn't yet have an approach to handle situations like that.

I'm running into the same issue. I installed the package today from pip (never used or installed it before), and "Burma" as an alternative to "Myanmar" is not available either.

from countryinfo import CountryInfo
CountryInfo("Burma").info()

throws the error KeyError: 'burma' I uninstalled the package and reinstalled it, the problem is still here. I'm under windows 10, Python 3.7, 64bits, the installed package version is countryinfo-0.1.2.

Maybe "Burma" is only available in the development version?

jeanbaptisteb avatar Feb 09 '22 18:02 jeanbaptisteb

Okay I had a look at the code and burma.json isn't loaded because it doesn't have a name entry. Since I'm just a passer-by, I can't speak on the intentions. The code that ignores those files is there since the first commit as far as I can tell.

FWIW, these files don't have a name set:

['antarctica.json',
 'ashmore_and_cartier_island.json',
 'burma.json',
 'clipperton_island.json',
 'europa_island.json',
 'gaza_strip.json',
 'glorioso_islands.json',
 'holy_see_vatican_city.json',
 'hungary.json',
 'ireland_northern.json',
 'jan_mayen.json',
 'jarvis_island.json',
 'johnston_atoll.json',
 'juan_de_nova_island.json',
 'midway_islands.json',
 'netherlands_antilles.json',
 'west_bank.json',
 'virgin_islands.json']

voidus avatar Feb 09 '22 23:02 voidus