Matthew Pope

Results 70 comments of Matthew Pope

> Most of these num traits were in the standard library before Rust 1.0, and were kicked out to live here instead. Do you know where I can find any...

Test vectors should include some expansion bombs to ensure they are handled correctly. C.f.: https://github.com/amazon-ion/ion-docs/pull/366#discussion_r1846587336

Many of the system macro tests are being implemented using `(text ...` fragments rather than `(toplevel ...`. Once `ion-java` and `ion-rust` support `(toplevel ...` we should consider going back and...

I think that there's another option here—we could say that values annotated with `$ion_...` were not really part of the user/application data model to begin with because the Ion 1.0...

Here's an edge case that needs to be addressed—how is `$ion_literal` data presented to the user/application—with or without the `$ion_literal` annotation? See https://github.com/amazon-ion/ion-tests/pull/138#discussion_r1859383312

The history will be preserved as part of this PR, even if it gets squashed when merging into the `ion-11-specification` branch. Is there a reason that is not enough? If...

Yes. I'll temporarily lift the restrictions on merge commits so that we can merge it as is. We generally prefer not to have merge commits, so I'll be reinstating the...

I don't have a strong preference for any of them. I think it's going to require weighing the costs and benefits of each. Here's why I think it's not simple...

Another potential solution is to change the binary encoding so that a no-arg-macro-shaped argument would no longer have a zero-sized representation. Suppose we have these macros: ``` (macro na ()...