popcode
popcode copied to clipboard
One true development environment fails when directory has spaces in it
Describe the bug
Issue occurs when attempting to run tools/setup.py in a directory that has spaces in it.
Directory is as follows: /Users/jessewang/Documents/Personal Code/popcode
Example Stacktrace:
tools/setup.py
* Install prebuilt node (10.16.2) ..... done.
bash: line 1: /Users/jessewang/Documents/Personal: No such file or directory
bash: line 1: /Users/jessewang/Documents/Personal: No such file or directory
/Users/jessewang/.nvm/versions/node/v8.12.0/bin/yarn -> /Users/jessewang/.nvm/versions/node/v8.12.0/lib/node_modules/yarn/bin/yarn.js
/Users/jessewang/.nvm/versions/node/v8.12.0/bin/yarnpkg -> /Users/jessewang/.nvm/versions/node/v8.12.0/lib/node_modules/yarn/bin/yarn.js
+ [email protected]
added 1 package in 0.315s
bash: line 1: /Users/jessewang/Documents/Personal: No such file or directory
error [email protected]: The engine "node" is incompatible with this module. Expected version "~10.16.2". Got "8.12.0"
error Found incompatible module.
To Reproduce
- Store the popcode repo in a folder that has spaces in it.
- Run
tools/setup.py
Expected behavior
tools/setup.py successfully runs and sets the node environment to the correct version.
- OS: iOS
- Version: Current master branch
Looks like this is an issue in nodeenv—there’s already an upstream issue https://github.com/ekalinin/nodeenv/issues/106 (several years old!)