Gnome 49 support

[CodeAndGin]

Well my Gnome 47 fix had a good run but bye bye x11 I guess

While the extension does load when adding "49" to the metadata, toggling tiling does nothing.

[Neo-29]

+1 ( archlinux wayland here)

[rafafrdz]

+1 (cachyos wayland here) added "49" and pluggin is enabled but toggling tiling doesn't work

[LilMonk]

+1 (cachyos wayland here) added "49" and pluggin is enabled but toggling tiling doesn't work

Same for me

[rr987-0]

i've made several function modifications get_maximized to is_maximized and some others but can exactly remember what but here is a version that works. https://drive.google.com/file/d/1g_SzZyO6HeDX0hS7fhQTzeEsDUVaT98r/view?usp=sharing just unzip it and replace .local/share/gnome-shell/extensions/[email protected] or diff it and figure out

[Neo-29]

i've made several function modifications get_maximized to is_maximized and some others but can exactly remember what but here is a version that works. https://drive.google.com/file/d/1g_SzZyO6HeDX0hS7fhQTzeEsDUVaT98r/view?usp=sharing just unzip it and replace .local/share/gnome-shell/extensions/[email protected] or diff it and figure out

Why not a PR?

[rafafrdz]

i've made several function modifications get_maximized to is_maximized and some others but can exactly remember what but here is a version that works. https://drive.google.com/file/d/1g_SzZyO6HeDX0hS7fhQTzeEsDUVaT98r/view?usp=sharing just unzip it and replace .local/share/gnome-shell/extensions/[email protected] or diff it and figure out

yes please, could you open a Pr with the changes? @rr987-0

[LilMonk]

@rafafrdz @CodeAndGin @Neo-29 You can check out this PR https://github.com/pop-os/shell/pull/1795 . Let me know if there are any bugs or issues with it. Its working fine for me on cachyos. Note: Need to reboot after installation.

[chrisjonesBSU]

@rafafrdz @CodeAndGin @Neo-29 You can check out this PR #1795 . Let me know if there are any bugs or issues with it. Its working fine for me on cachyos. Note: Need to reboot after installation.

This works for me on a VM with Gnome 49. Thanks!

[Neo-29]

not good here> Once you try to move a window manually, the extension stops working and all is in floating mode

Archlinux wayland

[chrisjonesBSU]

not good here> Once you try to move a window manually, the extension stops working and all is in floating mode

Archlinux wayland

Good catch, I didn't try that out. The same is happening for me.

[LilMonk]

I don't have that issue. I'm using V shell gnome extension for my vertical workspace setup.

[chrisjonesBSU]

This is on a fresh VM installation of EndeavourOS with no other extensions.

This appears in the logs right after clicking and dragging a window

Sep 24 12:47:41 chris-end gnome-shell[1626]: JS ERROR: TypeError: (intermediate value).Rectangle is not a constructor
                                             cursor_status@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/extension.js:2052:22
                                             on_grab_start/this.drag_signal<@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/extension.js:1096:52
                                             @resource:///org/gnome/shell/ui/init.js:21:20
Sep 24 12:47:42 chris-end gnome-shell[1626]: JS ERROR: TypeError: (intermediate value).Rectangle is not a constructor
                                             cursor_status@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/extension.js:2052:22
                                             on_drop@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/auto_tiler.js:249:39
                                             on_grab_end_@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/extension.js:830:41
                                             on_grab_end@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/extension.js:777:14
                                             signals_attach/</<@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/extension.js:1605:45
                                             run@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/extension.js:154:23
                                             wake/<@file:///home/chris/.local/share/gnome-shell/extensions/[email protected]/executor.js:26:24
                                             @resource:///org/gnome/shell/ui/init.js:21:20

[LilMonk]

Let me take a look at it. Might be some API changes in gnome 49

[LilMonk]

I have made the changes. It's working now. Reason for the error was The Meta.Rectangle is deprecated in gnome 49

Let me know if anything else breaks.

[Neo-29]

I have made the changes. It's working now. Reason for the error was The Meta.Rectangle is deprecated in gnome 49

Let me know if anything else breaks.

Is it updated on tar version or just PR?

[LilMonk]

Its PR right now

[Neo-29]

Its PR right now

Can you link the tar version updated? Easier to test

[LilMonk]

I think you need to do make local-install so that everything works correctly (keybindings). Just pull my PR branch and run make local-install and logout/reboot.

[chrisjonesBSU]

The latest changes seem to fix the issue for me.

[CodeAndGin]

@LilMonk lgtm ty

[Neo-29]

Not here

EDIT : ok here too , didn't use the good branch, my bad

[masmullin2000]

Thank you for the fix @LilMonk . Note to everyone who gets value from this fix that LilMonk has a buy me a coffee page. I have bought him a coffee, sorry that I could not provide the cream and sugar.

[LilMonk]

Thanks for the coffee @masmullin2000

[nitin88]

@LilMonk I still get occassionally this error

Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_cursor_location: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_surrounding: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_cursor_location: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_surrounding: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:20 fedora gjs[6711]: Gio.UnixOutputStream has been moved to a separate platform-specific library. Please update your code to use GioUnix.OutputStream instead.
                                  0 get() ["resource:///org/gnome/gjs/modules/core/overrides/Gio.js":524:46]
                                  1 <TOP LEVEL> ["file:///home/nigurr/.local/share/gnome-shell/extensions/[email protected]/floating_exceptions/main.js":210:5]

[LilMonk]

@LilMonk I still get occassionally this error

Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_cursor_location: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_surrounding: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_cursor_location: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_surrounding: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:20 fedora gjs[6711]: Gio.UnixOutputStream has been moved to a separate platform-specific library. Please update your code to use GioUnix.OutputStream instead.
                                  0 get() ["resource:///org/gnome/gjs/modules/core/overrides/Gio.js":524:46]
                                  1 <TOP LEVEL> ["file:///home/nigurr/.local/share/gnome-shell/extensions/[email protected]/floating_exceptions/main.js":210:5]

I think its a warning message rather than an error. Did you notice any abnormal behavior with the program? If any then mention the steps to reproduce it.

F.Y.I The above warning is because of a change in the GIO library structure, specifically concerning platform-specific components like UnixOutputStream. Gio.UnixOutputStream has been relocated to a dedicated, platform-specific library, now accessible as GioUnix.OutputStream.

[Neo-29]

@LilMonk I still get occassionally this error

Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_cursor_location: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_surrounding: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_cursor_location: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:17 fedora gnome-shell[3197]: clutter_input_focus_set_surrounding: assertion 'clutter_input_focus_is_focused (focus)' failed
Sep 25 09:40:20 fedora gjs[6711]: Gio.UnixOutputStream has been moved to a separate platform-specific library. Please update your code to use GioUnix.OutputStream instead.
                                  0 get() ["resource:///org/gnome/gjs/modules/core/overrides/Gio.js":524:46]
                                  1 <TOP LEVEL> ["file:///home/nigurr/.local/share/gnome-shell/extensions/[email protected]/floating_exceptions/main.js":210:5]

I think its a warning message rather than an error. Did you notice any abnormal behavior with the program? If any then mention the steps to reproduce it.

F.Y.I The above warning is because of a change in the GIO library structure, specifically concerning platform-specific components like UnixOutputStream. Gio.UnixOutputStream has been relocated to a dedicated, platform-specific library, now accessible as GioUnix.OutputStream.

Considering this, is there something to adapt in the source code of popshell? 🤔

[SakibShahariar]

perfectly working in fedora 43

[rafafrdz]

It works in CachyOs as well! ❤️

[Noob-linux-user]

Hi can you please tell me how to install this, i am noob

[LilMonk]

1. Clone my pr https://github.com/pop-os/shell/pull/1795
2. Run make local-install
3. Reboot/logout

For debugging, run make debug.

Refer readme for anything else.