shell icon indicating copy to clipboard operation
shell copied to clipboard

Launcher: text not visible in selection

Open coxackie opened this issue 6 years ago • 25 comments

This is using Adwaita: Screenshot from 2020-03-31 09-42-51 It appears that launcher works well with light shell themes, but text becomes invisible in dark variants.

coxackie avatar Mar 31 '20 08:03 coxackie

@isantop I think our chosen font color isn't very compatible with Adwaita's dark theme.

mmstick avatar Mar 31 '20 16:03 mmstick

I think I can fix that by simply removing the text color from the stylesheet, but we should caution that Pop Shell will not look good with any theme other than Pop.

isantop avatar Mar 31 '20 16:03 isantop

@isantop I understand that the priority for you guys is Pop, but it would be a great advertisement of the work that you do if you try to respect the shell theme, in order to be used widely. After all, you yourselves mention that you would like to propose this for upstream. A little extra thought here could take you a long way...

coxackie avatar Mar 31 '20 18:03 coxackie

by the way, this is with Pop-dark theme:

Screenshot from 2020-04-01 16-15-54

same issue, clearly.

coxackie avatar Apr 01 '20 15:04 coxackie

Not at all what I'm seeing

Screenshot from 2020-04-01 10-19-27

mmstick avatar Apr 01 '20 16:04 mmstick

@mmstick If a user sets the Pop-dark theme from tweak tool, then it will still use the light-mode stylesheet, producing this issue.

isantop avatar Apr 01 '20 17:04 isantop

@isantop this is exactly right. By the way, a bit off-topic (but related to the theme and gnome-tweaks), installing using deb files the latest 5.1.2 version of pop gtk-theme, only Pop-dark appears as an option in "Shell" at gnome-tweaks, the lighter Pop does not appear (but does appear in Applications, etc.) User of Arch linux, as I mentioned, and I have cross-validated this issue with the AUR package maintainer. Can you also see the issue in your local builds?

coxackie avatar Apr 01 '20 19:04 coxackie

That's something I'm aware of and is a side-effect of the current implementation of the build system. It's somewhat low-priority right now while we work towards the 20.04 release.

isantop avatar Apr 01 '20 19:04 isantop

no problem - as long as it is going to be fixed, it indeed does not feel like a priority. I mean, as long as it gets dealt with in time. You want people outside Pop!_OS to be able to use the themes, I hope.

EDIT: It appears that gnome-shell.css and gnome-shell-high-contrast.css are missing in the /themes/Pop/gnome-shell folder, and this is why vanilla Pop does not show as an option in "Shell" at gnome-tweaks. Should I open an issue at the gtk-theme repo?

coxackie avatar Apr 01 '20 19:04 coxackie

FWIW I just started having this issue as well. I installed arc-theme and a set of icons, tried them out for a bit, and switched back to Pop but now my launcher looks like this with the light theme:

Launcher Color

It looks fine with the dark theme and I've tried changing the theme both in tweaks and the appearance settings.

evanleck avatar Jul 07 '20 17:07 evanleck

It was happening to me as well but rebuilding using ./rebuild.sh a few days later fixed it. I am using the Ubuntu dark theme option and the launcher dialog does not seem to reflect that. image

GaryBer avatar Sep 29 '20 05:09 GaryBer

Text visibility issue is caused by any theme on Ubuntu that is not HighContrastInverse on Ubuntu 20.

image

image

GaryBer avatar Sep 29 '20 15:09 GaryBer

A workaround to make it work on dark themes with bright menus (like Ubuntu's Yaru mentioned above) is to force the choice of light style somehow, e.g.:

$ cp light.css dark.css
$ make local-install

Edit: this will render the search highlights illegible on actual dark themes of course ;)

ptrm avatar Apr 19 '21 16:04 ptrm

I've just experienced this issue, not long after a fresh OS install.

I switched to light mode and the colours were initially legible in the launcher. The only noteworthy things I can think of after that were installing some system updates, and rebooting. After reboot:

Screenshot from 2021-07-01 20-28-31

I also have gnome-tweak installed, but I don't think I'd touched any theme settings.

tobz1000 avatar Jul 01 '21 19:07 tobz1000

Thanks to all those who responded. I have not installed any themes or used gnome tweak to change themes--I was using the Light theme as chosen from Desktop->Appearance->Light straight out of the box (though I have upgraded this laptop through several versions). I switched it to Dark and now the text is visible. I hope this is addressed at some point, but (as some mentioned above) it is not a showstopper at all and easily worked around.

rmerren avatar Sep 20 '21 21:09 rmerren

This is now fixed for me - on master, latest commit is 1fddaa8953a6554a83038bb5662662eb761eb361. It's not immediately obvious to me how though. Commits between metadata version bump & now don't seem relevant to this issue.

Screenshot from 2021-10-31 03-39-52

Edit: I have recently removed tweak tools from my system.

aidenlangley avatar Oct 30 '21 14:10 aidenlangley

Could have been the change made for improving high contrast support.

mmstick avatar Oct 30 '21 15:10 mmstick

Edit: I have recently removed tweak tools from my system.

So, i had been having this problem to 1 month, and i solved now. I download the "User Theme" Extension for Gnome-Tweak an change the Shell theme to "Pop Dark", and solved the problem.

So, the bug is that gnome tweaks doesn't change the "shell" theme.

2021-12-08_18-54

Guztaver avatar Dec 08 '21 21:12 Guztaver

To expand on @Guztaver 's solution, after downloading User Theme Gnome Extension, I saw the following in the Gnome Tweaks "appearance" section. I am using PopOS 21.10.

This is what I saw with the "default" shell theme.

This is what I saw with after changing to the "pop dark" shell theme.

mds08011 avatar Jan 02 '22 06:01 mds08011

Switching via the "User Themes" extension has... changed the issue for me.

The "User Themes" UI only seems to change the colours of gnome-shell specific modals, e.g. the "Applications" menu, and the launcher. Below you can see that the launcher is dark, but my windows are still light. The text is at least readable now!

Screenshot from 2022-01-19 12-12-53

But now, the regular theme configuration panel under Settings -> Desktop -> Apperance seems to not control gnome-shell modals at all, only normal windows. Here I have dark mode set, but a light-theme modal:

Screenshot from 2022-01-19 12-16-24

This is fairly frustrating for me because I change between light and dark theme often, depending on my environment.

tobz1000 avatar Jan 19 '22 12:01 tobz1000

Still a relevant issue. This is unfortunate, as pop-shell is great but this makes it very hard to use for me Using the default Gnome theme with no customization

Guekka avatar Aug 15 '23 10:08 Guekka

Fixed this on Fedora by going to Tweaks->Appearance and changing Legacy Applications from Adwaita to Adwaita-dark. Only side effect is that all GTK3 apps turned to dark mode now.

HazemKaroui avatar Oct 07 '23 22:10 HazemKaroui

OMG so glad I found this thread! I have been just tolerating this issue for the longest time -- i.e. barely being able to read text, all GUI elements (sliders, radio buttons etc) being invisible and just having to guess at their locations. Downloaded the Tweak Tools and the User Themes and set the Shell to Pop-dark, restarted gnome, and I can finally read the menus properly! :partying_face:

drscotthawley avatar Nov 25 '23 23:11 drscotthawley

Setting the shell theme to Pop Dark does indeed fix the issue for the launcher, but it is starting to create issues on newer versions of GNOME, mainly in the quick settings panel. Im curious if anyone has found just some simple css to override the highlighted text color for whatever theme you are using? w/Pop-Dark image w/ Adwaita gnome-shell-screenshot-78w0qg This is on an arch install (boy i can't wait for COSMIC so i dont have to deal with GNOME anymore)

Edit: after a bit more sleuthing i was able to find a solution

i couldnt get it to take a local css override on the system, but as the comment says you can edit the text color on the system by modifying /usr/share/gnome-shell/extensions/[email protected]/light.css as sudo, and change color .pop-shell-search-element:select{ color: #393634; } from #393634 to #beeef7 (as just one example, use what you like)

jjanett avatar Feb 14 '24 01:02 jjanett