cosmic-text icon indicating copy to clipboard operation
cosmic-text copied to clipboard

Extract color overrides from `attrs_list` into new `color_spans` field

Open geieredgar opened this issue 3 years ago • 2 comments

This is a follow up for #100. It removes the color_opt field from Attrs and stores the information in the new color_spans field of BufferLine instead. This allows it to be mutated without having to do relayouts.

Fixes #69.

geieredgar avatar Mar 06 '23 19:03 geieredgar

this looks very promising, However You probably should move Metadata in with the Color as these are ones that don't affect the Layout.

genusistimelord avatar Mar 30 '23 14:03 genusistimelord

Might also be Worth it to allow the End user to get a Mutable Span if one Already Existed so they can update it rather than replace it. what do you think @jackpot51 ?

genusistimelord avatar Mar 30 '23 14:03 genusistimelord