cosmic-protocols icon indicating copy to clipboard operation
cosmic-protocols copied to clipboard

WIP atspi: `add_virtual_modifier` request

Open ids1024 opened this issue 1 year ago • 2 comments

ids1024 avatar Nov 07 '24 20:11 ids1024

So would this mean we ignore virtual_mods send by the key-grabs now? Should this have been split from the start?

Drakulix avatar Nov 07 '24 20:11 Drakulix

The virtual_mods part of the grab is still used to match the grab (so the key isn't sent by applications if the modifiers and virtual modifiers are held when it is pressed, but otherwise is handled normally).

It probably should have worked this way originally, but luckily it isn't difficult to add.

ids1024 avatar Nov 07 '24 22:11 ids1024

With https://github.com/pop-os/cosmic-comp/pull/1412, we are now using the new upstream DBus protocol, so this is no longer needed.

ids1024 avatar Nov 24 '25 21:11 ids1024