cosmic-files icon indicating copy to clipboard operation
cosmic-files copied to clipboard

[bug] File picker shows duplicate "Open" buttons with the quick preview open

Open alphabitserial opened this issue 1 year ago • 5 comments

Cosmic-files version: 1.0.0.alpha.2.r20.g8dd26b6-1

Issue/Bug description: The file picker already has an "Open" button at the bottom of the window for confirming my selection, but right next to it is the quick preview pane's "Open" button. This creates unnecessary visual noise and potential confusion for less technically savvy users.

Steps to reproduce: Open the file picker dialog and click an image, opening the quick preview pane. For example, I have Firefox config key widget.use-xdg-desktop-portal.file-picker set to 1 to use COSMIC Files instead of the GTK picker.

Expected behavior: The quick preview panel's "Open" button should open the file in the default application. The button at the bottom of the file picker should be relabeled "Select".

Other notes: See screenshot image

alphabitserial avatar Oct 03 '24 03:10 alphabitserial

  • Open button at the bottom should upload or open in requested app
  • Open button in details pane should open item in default app.

Currently both opens/upload the item in requested app/website.

iamkartiknayak avatar Oct 03 '24 04:10 iamkartiknayak

Should the two labels be disambiguated? Maybe the Open button at the bottom could be labeled "Select" or "Confirm"

alphabitserial avatar Oct 03 '24 06:10 alphabitserial

Yeah, renaming the picker dialog button to select would be more appropriate.

iamkartiknayak avatar Oct 03 '24 06:10 iamkartiknayak

I’ve noticed this preview menu comes up when I click a file instead of popping up when I right click and choose it like I would expect it’s more noticeable on Asahi Linux

m1m1k4tz avatar Oct 03 '24 16:10 m1m1k4tz

I've updated the "expected behavior" portion of my original comment to reflect Kartik's comments :+1:

alphabitserial avatar Oct 03 '24 20:10 alphabitserial