cosmic-files icon indicating copy to clipboard operation
cosmic-files copied to clipboard

[BUG] Details pane not showing image preview despite having thumbnailer support

Open iamkartiknayak opened this issue 1 year ago • 2 comments

Cosmic-files version:

cosmic-files:
  Installed: 0.1.0~1727456658~24.04~5e0ef57

Issue/Bug description: Cosmic Files does not recognize certain image formats such as .heic, even after installing and configuring the appropriate thumbnailer support for those formats. It shows the thumbnail of image in navigation view but doesn't produce preview in preview pane or in gallery view.

Steps to reproduce:

https://github.com/user-attachments/assets/dba8cd0a-7eb8-4729-9e3c-25cb778ceaa8

Expected behavior: Thumbnails should be displayed in preview pane & Gallery view, provided that the necessary thumbnailer support is correctly installed. In case if thumbnailer is not setup a generic image should be used in preview pane & Gallery view should not execute .

Other notes:

iamkartiknayak avatar Sep 28 '24 07:09 iamkartiknayak

I believe this is because cosmic-files uses widget::image() but does not manually create the image using thumbnailer. I am not particularly sure how this could work, cosmic could potentially rely on the thumbnailer for this considering that %s is optional, however in reality i am not sure how reliable this is. Perhaps cosmic-files could abstract out image decoding into a seperate function that could be shared across widget::image() and the thumbnailer

Quackdoc avatar Jan 29 '25 11:01 Quackdoc

Still a issue in Alpha-6 for .heic image format

iamkartiknayak avatar Mar 07 '25 21:03 iamkartiknayak

I am working on a PR to add support for jxl for the preview and gallery view, "In case if thumbnailer is not setup a generic image should be used in preview pane & Gallery view should not execute"

Is there an good image somewhere? I want to use a fallback image for when jxl fails to encode and figure it should wind up being the same one as this.

as an additional question since I'm working on this anyways, is it guaranteed that a thumbnailer will produce acceptable results? I had at least one thumbnailer in the past force you to enter a value, and would always produce a square image. Would it be better to throw the generic image instead?

Quackdoc avatar Aug 01 '25 04:08 Quackdoc