cosmic-files icon indicating copy to clipboard operation
cosmic-files copied to clipboard

Published 20 hours ago • verified publisher icon pop-os

Feature: add file previews

Open maria-komarova opened this issue 10 months ago • 3 comments

File preview should open simultaneously with selecting folder or file by clicking on it. Home-grid-preview Figma mockups.

maria-komarova avatar Apr 12 '24 15:04 maria-komarova

Maybe also details specific to the file type (e.g. video length, image size) under the preview, kinda like Dolphin (KDE)?

00-kat avatar Apr 13 '24 12:04 00-kat

I've seen a (harsh) complaint about the file preview overlapping the content view which makes navigating through files with the keyboard difficult in this video: https://youtu.be/KP3dOUJgng0&t=136 Timestamp is included in the link. This probably only affects the grid view.

One easy fix for this I can think of is to shrink the content view when the file preview is opened so the two layers don't overlap. This would increase the amount of scrolling required to reach the bottom of the content view, but that's probably more acceptable than not being able to see what files are being selected.

M00NJ avatar Jun 09 '24 08:06 M00NJ

One easy fix for this I can think of is to shrink the content view when the file preview is opened so the two layers don't overlap.

It's worth mentioning that if that's the fix system76 is going after, the grid view will change considerable with previews. If you open and close the preview, it will do quite a dance for the user to see.

guilhermeaiolfi avatar Jul 11 '24 17:07 guilhermeaiolfi

The designs for File previews have been updated. The layout should follow the pattern where ContextDrawer opens next to the content area making the content re-flow. The behavior and responsiveness is described here in the Design System.

Small video demonstrating how the app should shrink.

https://github.com/user-attachments/assets/9654bd93-f146-405e-9e7b-977effeb0220

Another video shows the interaction with the file preview when the content area is at its minimum width.

https://github.com/user-attachments/assets/8bb52681-d243-4d21-a3a3-2b0e30366231

Mockups used for the prototypes.

maria-komarova avatar Sep 05 '24 15:09 maria-komarova

List of items to resolve:

  • [x] Allow context drawer to optionally be placed on the same layer as content
  • [x] Change breakpoint when context drawer is open and on the same layer
  • [x] When grid view is resized, scroll as needed so selected item remains in view
  • [x] Add timer after clicking an item to show a preview if double click expires

jackpot51 avatar Sep 20 '24 15:09 jackpot51