poozle icon indicating copy to clipboard operation
poozle copied to clipboard

Setup basic OAuth for extensions

Open harshithmullapudi opened this issue 1 year ago • 0 comments

We need to setup basic OAuth for extension

  • [ ] Connect buttons in frontend
  • [ ] Callback handling service
  • [ ] Dropdown of scopes in frontend

harshithmullapudi avatar Apr 27 '23 08:04 harshithmullapudi

Will investigate this.

manuel12 avatar Jun 08 '23 08:06 manuel12

@gbowne1 Is this currently happening? I'm having difficulty trying to reproduce the issue :/

Just to explain how the current functionality is now, after using now front-end and back-end:

  • localStorage is not used anymore for storing testuser credentials, these are stored in the backend db by default when the db is created, hence why these credentials are always available.
  • The validation is only run when the submit button(login/register) is pressed, so right now functionality is not that the red warning label around inputs will automatically disappear if say, you have 7 characters in password input and then you add an 8th, in this case red label will remain. Instead once you click login/register the red label will disappear, as a new validation will be ran. This is to prevent all inputs being red from the beginning, because if we run validation when page is loaded and all inputs are empty then all inputs will be red.

In any case I will keep trying to reproduce the issue and fix it if I get it, if there's anything more I can do to reproduce please write me here in a comment :)

manuel12 avatar Jun 08 '23 09:06 manuel12

it only happens sometimes. I have the test creds saved in my browser. When applied it automatically turns the field red like shown. If I go back through, like refresh, log out, then try logging in again, this does not happen. It's intermittent.

gbowne1 avatar Jun 08 '23 09:06 gbowne1

I will add an automated test that checks this, this way anytime anyone runs the e2e tests this will be checked, adn we will catch it if happens again.

manuel12 avatar Jun 08 '23 09:06 manuel12

Good idea. Just curious that a ten character autocompleted password would turn it red and display the error.

gbowne1 avatar Jun 08 '23 09:06 gbowne1

I still have not been able to nail down whats causing this either.

gbowne1 avatar Oct 06 '23 06:10 gbowne1

@manuel12 have we solved this or is this stil pretty much a non issue?

gbowne1 avatar Oct 31 '23 17:10 gbowne1

@manuel12 have we solved this or is this stil pretty much a non issue?

Need to check it again: I remember in the past I managed to reproduce this in Firefox when the browser autocompleted your password. I will look into this soon.

manuel12 avatar Nov 01 '23 10:11 manuel12

Ok great thanks @manuel12

gbowne1 avatar Nov 01 '23 21:11 gbowne1