hyde icon indicating copy to clipboard operation
hyde copied to clipboard

Rename /public to /assets, as the latter is the special directory

Open glebius opened this issue 7 years ago • 3 comments

Hi!

I tried to use hyde together with https://github.com/benbalter/jekyll-remote-theme. This gem allows to host a website with GitHub Pages with any GitHub-hosted theme (not only supported by Pages). It puts remote theme to a temporary directory, compiles _site and deletes temporary. This yielded in files missing from the generated website:

[2017-11-21 00:43:00] ERROR /public/css/poole.css' not found. [2017-11-21 00:43:00] ERROR /public/css/syntax.css' not found. [2017-11-21 00:43:00] ERROR `/public/css/hyde.css' not found.

This happens because Jekyll doesn't treat /public as a special directory. See https://jekyllrb.com/docs/themes/. Putting stylesheets and icons into /assets fixes the problem.

glebius avatar Nov 21 '17 09:11 glebius

As far as I know, there's nothing special about public.

mdo avatar Nov 25 '17 01:11 mdo

Exactly, there is nothing special about "public", but there is about "assets". And we need it be special to be copied over.

glebius avatar Nov 27 '17 16:11 glebius

Oh well shit, I misread that one. I dunno when I'll get to this and the other themes though.

mdo avatar Nov 27 '17 16:11 mdo