hyde icon indicating copy to clipboard operation
hyde copied to clipboard

Update for Poole 2 and Jekyll 3

Open mathiasvr opened this issue 9 years ago • 4 comments

Hi, this PR brings in the changes from Poole 2 for Jekyll 3 support.

I know there are already a bunch of pending pull requests, but I am sharing this anyway in case somebody wants a working theme for Jekyll 3. Get the complete theme here.

Notes:

  • sidebar.html might need better HTML5 tags
  • hyde.css has not been converted to scss

mathiasvr avatar Feb 19 '16 17:02 mathiasvr

good stuff in there :)

qwtel avatar Feb 25 '16 09:02 qwtel

Thanks for this @mathiasvr. I made most of your updates and I'm very happy with the results. I don't have much experience in web dev, why is the baseurl change from "/" to "" in _config.yml a good idea?

@qwtel - Very cool what you've done with your site, especially the sidebar. I did have a question on small screens... if you click on the menu icon to bring up the sidebar, there's no way to get the sidebar to disappear without refreshing or clicking on one of the sidebar links right? I was thinking of trying to implement something similar for my site but I think I'd either want the expanded sidebar to take up the entire screen (or moved to top) or I'd like to have some way to close out of it if covers other portions of the content (similar to lanyon but without actually moving the content to the right).

jilmun avatar Feb 25 '16 13:02 jilmun

Glad you like it :) It's still work in progress and currently assumes that you are using a touch device for the small screen layout. Closing the menu bar works via swiping to the left or tapping on the backdrop.

Regarding your site, my current implementation should still work if you set .sidebar { width: 100%; left: -100%} but again it's unfinished and relies on JS (the lanyon one is CSS only which is pretty cool).

qwtel avatar Feb 25 '16 14:02 qwtel

@jjwesner The updated files are based on the current version of Poole which amongst other things sets the baseurl to "". This is also the default configuration when creating a new Jekyll 3 project.

mathiasvr avatar Feb 25 '16 16:02 mathiasvr