thunderlink icon indicating copy to clipboard operation
thunderlink copied to clipboard

Published 20 hours ago • verified publisher icon poohsen

Recent merges

Open simonthum opened this issue 9 years ago • 5 comments

Hi,

please not that my PR #25, since it came from master, got updated to contain lots of stuff that perhaps shouldn't have been merged. Notably, I added a -simon to the version to avoid ambiguities and added packaged versions thereof.

You may want to get rid of that.

simonthum avatar Dec 08 '15 13:12 simonthum

I'm not bothered by that .xpi file. The other commits looked fine at first glance. Is there anything I need to look at specifically? I wanted to take some time to test yesterday but ended up wasting it on Ubuntu compiz issues when running in vbox. This has been one of the reasons why I haven't been actively developing TL: I Can't setup a working testing env on my macbook...

poohsen avatar Dec 08 '15 16:12 poohsen

Well, the XPI is probably OK but the version string got a "-simon" from me so I'd know what's going on from the Addons Tab. This will end up on AMO if you don't remove it, and I don't feel like having done such a great job here to deserve a designation ;)

Anyway, the plugin XPI works for me, without regressions AFAICT, so the xpi should be fine.

simonthum avatar Dec 09 '15 08:12 simonthum

how so? the repo isn't linked to mozilla in any way suitable for automatic pulling of XPIs. I upload new versions to AMO manually when they're done, so no problem there. Unless I missed some cool new AMO feature

poohsen avatar Dec 09 '15 11:12 poohsen

Not automatically, but see

https://github.com/poohsen/thunderlink/blame/master/install.rdf#L7

simonthum avatar Dec 09 '15 12:12 simonthum

ah yes. that's right. I missed that change in the diff. thx!

poohsen avatar Dec 09 '15 13:12 poohsen