Alex Seaton

Results 20 comments of Alex Seaton

Some of these might already be fixed, we should check. Step 1 of this should be a writeup with analysis of the current state of prune previous versions. Step 2...

https://github.com/man-group/ArcticDB/pull/1769

Change looks fine. What test coverage do we have for our SSL interaction? Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual...

> > Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual test if not. > > @poodlewars It is on now. @phoebusm...

Thanks @tschm and sorry I've only just seen this one. It looks good to me, if you could just sign the commit per https://github.com/man-group/ArcticDB/blob/master/Individual%20Contributor%20License%20Agreement.md#7-acceptance , drop the merge commits, and...

> @poodlewars Like this? Yep, exactly

> Thanks @tschm and sorry I've only just seen this one. > > It looks good to me, if you could just sign the commit per https://github.com/man-group/ArcticDB/blob/master/Individual%20Contributor%20License%20Agreement.md#7-acceptance , drop the...

We don't necessarily need to do end to end benchmarks. As discussed should also consider: - Alerting on the nightly build, so that we realise if it fails - Full...

We should set up our own AWS EKS cluster so we can test this properly.

I've been setting up a test AWS EKS cluster to help with this. I've put the deployment files here: https://github.com/poodlewars/scratch/tree/k8s-files . ``` . ├── deployment.apps │   └── eks-sample-linux-deployment.yaml ├── service...